Emacs-Auto-Dark (development branch feedback)

General
1

Continuing the discussion from Emacs Solo: A Minimal IDE Configuration - System Crafters Live!:

@LionyxML moving this chat about auto-dark over from the main thread.

I tried out the development branch and it’s not auto switching. I use Straight for package management, switched to development branch, pulled, rebuild auto-dark, restarted. Disabled and enabled auto-dark. But it’s no longer switching my themes. Let me know how to grab logs/etc. And i’d be happy to test more.

Details:

  • GNU Emacs 29.3 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2024-04-04
  • Pop!_OS 22.04 LTS
  • GNOME 42.9 (yikes that’s old)
1 Like
2

Sure thing!

There are two reasons why I am now almost 5 months late with merging the development branch:

  • I need time to proper test it
  • We WILL add breaking changes

We are deprecating auto-dark-dark-theme and auto-dark-light-theme in favour of auto-dark-themes.

This is the new way of setting up auto-dark:

(use-package auto-dark
  :ensure t
  :custom
  (auto-dark-themes '((wombat) (leuven)))
  :hook
  :init (auto-dark-mode))

You can check its docs here: auto-dark-emacs/auto-dark.el at 1b6c1841c5b15388ee78cb03a4139fd14f42783b · LionyxML/auto-dark-emacs · GitHub

Let me know if this works for you!

1 Like
3

Didn’t even think to look for breaking changes. I’ll look at the docs, change the config and report back tomorrow. Thanks for the heads up!
Breaking changes are always tricky, are you able to deprecate the methods instead? At (first) launch if auto-dark-themes alist isn’t present check for auto-dark-light-theme and auto-dark-dark-theme and then save auto-dark-themes with the values found?

1 Like
4

Both auto-dark-dark-theme and auto-dark-light-theme are marked deprecated. But I think you’d have to C-h v over it to know about it ;/

There’s no automatic importing of anything because that would imply setting stuff on custom file, so you’d still have (setq auto-dark-light-theme 'leuven) on your config, and making a change to something like (setq auto-dark-light-theme 'modus-operandi) would probably have no effect on an already customized auto-dark-themes (set by a an automatic importing tool, for example).

I admittedly have not gave it a proper though, but I’ll probably mass span the braking changes here and on reddit, also adding it to README and ‘hope for the best’ :smiley:

1 Like